From 57bfb058d5f7c92a56dd8910400a1815e27245fb Mon Sep 17 00:00:00 2001 From: Saj Goonatilleke Date: Thu, 18 Mar 2021 00:30:42 +1100 Subject: [PATCH] mapper: correct text/binary typo Fixes a panic when attempting to make use of pointers to types that implement encoding.BinaryUnmarshaler. e.g.: type SomeBinaryFlag struct{} func (f *SomeBinaryFlag) UnmarshalBinary(data []byte) error { // ... return nil } var cli struct { Binary *SomeBinaryFlag } --- mapper.go | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/mapper.go b/mapper.go index 7eb77fb..b8447ec 100644 --- a/mapper.go +++ b/mapper.go @@ -84,7 +84,7 @@ func (m *binaryUnmarshalerAdapter) Decode(ctx *DecodeContext, target reflect.Val if err != nil { return err } - if target.Type().Implements(textUnmarshalerType) { + if target.Type().Implements(binaryUnmarshalerType) { return target.Interface().(encoding.BinaryUnmarshaler).UnmarshalBinary([]byte(value)) } return target.Addr().Interface().(encoding.BinaryUnmarshaler).UnmarshalBinary([]byte(value))