gopkg/gin
2
0
Fork 0
Code Pull Requests Activity

Don't log requests (#1370)

Browse Source 
Fixes #1331

HTTP logging leaks sensitive request information.

This PR removes HTTP request logging during panics.
This commit is contained in:
Dustin Decker
2018-09-23 00:15:23 -07:00
committed by Bo-Yi Wu
parent 5a75dc7127
commit ad53619b15
2 changed files with 17 additions and 3 deletions
Download Patch File Download Diff File Expand all files Collapse all files
recovery.go
+6 -2
View File
@@ -39,8 +39,12 @@ func RecoveryWithWriter(out io.Writer) HandlerFunc {
if err := recover(); err != nil {
if logger != nil {
stack := stack(3)
httprequest, _ := httputil.DumpRequest(c.Request, false)
logger.Printf("[Recovery] %s panic recovered:\n%s\n%s\n%s%s", timeFormat(time.Now()), string(httprequest), err, stack, reset)
if IsDebugging() {
httprequest, _ := httputil.DumpRequest(c.Request, false)
logger.Printf("[Recovery] %s panic recovered:\n%s\n%s\n%s%s", timeFormat(time.Now()), string(httprequest), err, stack, reset)
} else {
logger.Printf("[Recovery] %s panic recovered:\n%s\n%s%s", timeFormat(time.Now()), err, stack, reset)
}
}
c.AbortWithStatus(http.StatusInternalServerError)
}